Load units embedded into MUL file #6163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6163 +/- ##
============================================
- Coverage 29.18% 29.18% -0.01%
+ Complexity 13974 13973 -1
============================================
Files 2623 2623
Lines 266441 266476 +35
Branches 47594 47600 +6
============================================
- Hits 77774 77773 -1
- Misses 184765 184800 +35
- Partials 3902 3903 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for unit files to be embedded in a MUL file:
The construction_data field contains a base64'd and gzipped version of this unit's mtf (or blk) file.
If such a MUL file (test.zip) is loaded in MM or MML with this PR, the file will load successfully, even if you don't have the contained custom marauder available.
THIS PR DOES NOT PROVIDE A WAY TO CONSTRUCT SUCH A MUL FILE, IT ONLY ENABLES THEM TO BE LOADED.
This PR provides the code necessary to create a MUL file with custom units embedded, but there is no way to invoke this code from the GUI.
Support for creating these MUL files will come in future PRs for MM and MML.